deployOpChain using OPCM #12291
Merged
deployOpChain using OPCM #12291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maurelian and the rest of your teammates on |
|
Semgrep found 2 require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 2 Prefer Semgrep found 4
Javadoc-style comments are not allowed. Use |
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
807e4ea
to
9f8dc75
Compare
maurelian
force-pushed
the
opcm/tests/deploy-opcm
branch
from
03bc78f
to
c814258
Compare
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
2 times, most recently
from
af9473e
to
5ad8e76
Compare
maurelian
changed the base branch from
opcm/tests/deploy-opcm
to
feat_Move_DEFAULT_STARTING_ANCHOR_ROOTS_to_Constants_library
maurelian
force-pushed
the
feat_Move_DEFAULT_STARTING_ANCHOR_ROOTS_to_Constants_library
branch
4 times, most recently
from
8ef9390
to
99ca905
Compare
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
5ad8e76
to
f6b1436
Compare
maurelian
force-pushed
the
feat_Move_DEFAULT_STARTING_ANCHOR_ROOTS_to_Constants_library
branch
4 times, most recently
from
bcc0fba
to
dc94f66
Compare
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
f6b1436
to
0b0f292
Compare
Base automatically changed from
feat_Move_DEFAULT_STARTING_ANCHOR_ROOTS_to_Constants_library
to
develop
October 4, 2024 20:24
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
c255091
to
be99aec
Compare
Makes debugging slightly easier.
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
be99aec
to
0dffeb7
Compare
At this point tests that depend on the L2OutputOracle will still fail, but those with Fault Proofs _should_ pass.
It no longer handles the PERMISSIONED game type deploy by OPCM.
THis is necessary because the tests assume the respecte game is cannon, but the OPCM assumes it is the permissioned game
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
a3498b9
to
5b0627c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12291 +/- ##
===========================================
- Coverage 64.10% 63.91% -0.19%
===========================================
Files 52 52
Lines 4312 4312
===========================================
- Hits 2764 2756 -8
- Misses 1374 1383 +9
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
3 times, most recently
from
3430d79
to
307a97d
Compare
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
307a97d
to
14998cb
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
|
Semgrep found 1 TODO in error handling code Ignore this finding from err-todo. |
maurelian
force-pushed
the
opcm/tests/deploy-opchain
branch
from
ba0c4e3
to
3287bdc
Compare
mds1
approved these changes
Oct 11, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat: move log to top of save function Makes debugging slightly easier. * feat: Deploy system with OPCM * feat: Deploy missing Permissionless DWETH * feat: Fully OPCM based deployment At this point tests that depend on the L2OutputOracle will still fail, but those with Fault Proofs _should_ pass. * feat: Refactor _setFaultGameImplementation It no longer handles the PERMISSIONED game type deploy by OPCM. * test: Make caller explicit in unauthorized test case * test: Fix have guardian setRespectedGameType to Cannon THis is necessary because the tests assume the respecte game is cannon, but the OPCM assumes it is the permissioned game * test: Bridge_Initializer defaulst to FP on * test: setRespectedGameType to Cannon in Deploy * test: Bridge_Initializer defaulst to FP on * feat: resetInitializedProxy func to allow reinitializing contracts * feat: Delete initializeOpChain, we don't need it anymore * feat: Set batch inbox address in config using hashed method * feat: Make caller explicit in testFuzz_removeDependency_notDependencyManager_reverts * feat: lint * Revert "test: Bridge_Initializer defaulst to FP on" This reverts commit d435653. * feat: Consolidate useFaultProofs modifications into _run * Revert "test: Bridge_Initializer defaulst to FP on" This reverts commit af8d99b. * feat: Some annotations in Deploy.s.ol * feat: Skip checking L2OO in Initializable.t.sol * feat: Delete unused initialize functions * fix: Remove unused imports * fix: unused import * feat: Use respectedGameType from deploy-config * use startPrank * feat: Prevent deploying legacy portal for interop * fix: incorrect var name * feat: detect when OPCM is deploying the Permissionless game * fix: error format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies Deploy.s.sol with two high level changes:
are handled with follow up actions.